Added Directory.Packages.props, updated dependencies and target frame…#10
Merged
Added Directory.Packages.props, updated dependencies and target frame…#10
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency and project configuration files while making minor code refactoring improvements for clarity and consistency. Key changes include renaming type parameters to improve semantic meaning, enforcing sealed classes where appropriate, and updating workflow and GitVersion configurations.
Reviewed Changes
Copilot reviewed 23 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/AppCoreNet.Data.MongoDB/MongoDataProvider.cs | Renamed generic parameter from TEntity to TDocument to better reflect MongoDB document semantics |
| src/AppCoreNet.Data.EntityFrameworkCore/Internal/LogEventIds.cs | Added a ReSharper directive to disable namespace check |
| src/AppCoreNet.Data.EntityFrameworkCore/Internal/EntityModelProperties.cs | Marked the class as sealed for improved maintainability |
| src/AppCoreNet.Data.EntityFrameworkCore/Internal/DbModelProperties.cs | Updated tuple key naming in the ConcurrentDictionary for clarity |
| src/AppCoreNet.Data.EntityFrameworkCore/DbContextRepository.cs | Reformatted lambda blocks for logging and updated asynchronous disposal method naming |
| src/AppCoreNet.Data.AutoMapper/AutoMapperDataProviderBuilderExtensions.cs | Improved method signature formatting |
| src/AppCoreNet.Data.Abstractions/EntityExtensions.cs | Fixed a spelling typo in the XML documentation for the IsTransient method |
| GitVersion.yml | Revised configuration settings for Git versioning |
| .github/workflows/build-test.yaml | Upgraded GitHub Action versions and updated the targeted .NET version |
Files not reviewed (10)
- AppCoreNet.Data.sln: Language not supported
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- NuGet.config: Language not supported
- global.json: Language not supported
- renovate.json: Language not supported
- src/AppCoreNet.Data.Abstractions/AppCoreNet.Data.Abstractions.csproj: Language not supported
- src/AppCoreNet.Data.AutoMapper/AppCoreNet.Data.AutoMapper.csproj: Language not supported
- src/AppCoreNet.Data.EntityFrameworkCore/AppCoreNet.Data.EntityFrameworkCore.csproj: Language not supported
- src/AppCoreNet.Data.MongoDB/AppCoreNet.Data.MongoDB.csproj: Language not supported
Comments suppressed due to low confidence (3)
src/AppCoreNet.Data.MongoDB/MongoDataProvider.cs:68
- Changing the generic parameter name from TEntity to TDocument improves clarity for MongoDB documents. Please ensure that any related references are updated accordingly.
internal string GetCollectionName<TDocument>()
src/AppCoreNet.Data.EntityFrameworkCore/DbContextRepository.cs:281
- The asynchronous disposal method has been renamed to DisposeQueryHandlerAsync, which aligns with async naming conventions. Confirm that all related documentation and call sites reflect this updated name.
await DisposeQueryHandlerAsync(queryHandler)
.github/workflows/build-test.yaml:29
- [nitpick] The workflow now uses version 4 of the setup-dotnet action and targets .NET 9.0.x; ensure that these updates are compatible with your build environment and that documentation is revised accordingly.
uses: actions/setup-dotnet@v4
| /// <typeparam name="TId">The type of the entity id.</typeparam> | ||
| /// <param name="entity">The entity.</param> | ||
| /// <returns><c>tru</c> if the entity is transient; <c>false</c> otherwise.</returns> | ||
| /// <returns><c>true</c> if the entity is transient; <c>false</c> otherwise.</returns> |
There was a problem hiding this comment.
The XML documentation was updated to correct a spelling typo from 'tru' to 'true'. This improves clarity for consumers of the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…works.